Skip to content

Fix issue #76: next sprint item (P2): Dogfood: run ShellFor…#126

Merged
jpleva91 merged 1 commit intomainfrom
clawta/brain-76-1775375551
Apr 5, 2026
Merged

Fix issue #76: next sprint item (P2): Dogfood: run ShellFor…#126
jpleva91 merged 1 commit intomainfrom
clawta/brain-76-1775375551

Conversation

@jpleva91
Copy link
Copy Markdown
Contributor

@jpleva91 jpleva91 commented Apr 5, 2026

Auto-generated by Clawta via Octi Pulpo dispatch

Task: brain-76-1775375551
Adapter: clawta
Type: code-gen

- When isServer=true (headless Linux without GPU), offer OLLAMA_HOST configuration
- Allow Goose installation on server mode (works with remote Ollama via OLLAMA_HOST)
- Update setup wizard to guide users through remote GPU endpoint setup
- Keep backward compatibility for local Ollama on Mac/GPU systems

This enables dogfood on jared-box (headless WSL2 + RunPod GPU) by allowing
remote Ollama configuration instead of skipping Ollama entirely.
Copilot AI review requested due to automatic review settings April 5, 2026 07:56
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the ShellForge setup wizard to better support “server mode” (Linux without GPU) by guiding users toward remote Ollama usage and enabling Goose as a driver in that environment.

Changes:

  • Replace the server-mode “skip Ollama” messaging with an interactive remote Ollama (OLLAMA_HOST) configuration prompt.
  • Offer/install Goose in both local and server modes, with server-specific guidance for remote Ollama usage.
  • Update the final setup summary to include remote Ollama + Goose usage hints in server mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -155,9 +155,26 @@ model := ""
// ── Step 1: Ollama (skip on headless server) ──
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The step header comment says Ollama is “skip[ped] on headless server”, but server mode now performs remote Ollama (OLLAMA_HOST) configuration. Update this comment to match the new behavior so future edits don’t reintroduce the old assumption.

Suggested change
// ── Step 1: Ollama (skip on headless server) ──
// ── Step 1: Ollama setup (local install or remote OLLAMA_HOST on server) ──

Copilot uses AI. Check for mistakes.
Comment on lines +161 to +166
fmt.Print(" Configure remote Ollama (OLLAMA_HOST) for GPU endpoint? [Y/n] ")
if confirm(reader) {
fmt.Print(" Enter OLLAMA_HOST (e.g., http://192.168.1.100:11434): ")
ollamaHost := readLine(reader)
if ollamaHost != "" {
fmt.Printf(" → Set OLLAMA_HOST=%s before running shellforge\n", ollamaHost)
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In server mode, these prompts use confirm()/readLine(), which treat EOF/empty input as “yes”. If shellforge setup is run non-interactively (stdin closed/EOF), it will auto-enter the remote configuration flow and emit potentially confusing output. Consider detecting non-TTY/EOF and defaulting to “no” (skip prompts) in server mode.

Copilot uses AI. Check for mistakes.
Comment on lines 341 to 344
} else {
fmt.Println(" ⚠ Install failed — try: brew install --cask block-goose")
}
}
Copy link

Copilot AI Apr 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install-failure hint always suggests brew install --cask block-goose, which is misleading on Linux/server mode (where brew likely isn’t available and the attempted installer was the curl/bash script). Adjust the fallback guidance based on GOOS (e.g., re-run the GitHub installer script, link to Goose install docs, or provide apt/yum instructions) so server users aren’t sent down the wrong path.

Suggested change
} else {
fmt.Println(" ⚠ Install failed — try: brew install --cask block-goose")
}
}
} else {
if runtime.GOOS == "darwin" {
fmt.Println(" ⚠ Install failed — try: brew install --cask block-goose")
} else {
fmt.Println(" ⚠ Install failed — try re-running:")
fmt.Println(" curl -fsSL https://github.com/block/goose/releases/download/stable/download_cli.sh | bash")
fmt.Println(" See Goose install docs: https://github.com/block/goose")
}
}
}

Copilot uses AI. Check for mistakes.
@jpleva91 jpleva91 merged commit b9a19e0 into main Apr 5, 2026
10 checks passed
@jpleva91 jpleva91 deleted the clawta/brain-76-1775375551 branch April 5, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants